'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
…y in config.txt by the supervisor
The supervisor will now write the following dtoverlay setting
"gpio-key,gpio=4,active_low=0,gpio_pull=down"
into config.txt in the following form:
dtoverlay=gpio-key dtparam=gpio=4 dtparam=active_low=0 dtparam=gpio_pull=down
So we need to rework the test to account for these changes.
Change-type: patch
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines