is_secured will use command to check whether user_mode_enabled is defined, which was added to prevent the error message user_mode_enabled: command not found as this is only defined on EFI systems. However now on EFI systems it echoes user_mode_enabled each time the command is found which is also not what we want.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
is_secured will use
command
to check whetheruser_mode_enabled
is defined, which was added to prevent the error messageuser_mode_enabled: command not found
as this is only defined on EFI systems. However now on EFI systems it echoesuser_mode_enabled
each time the command is found which is also not what we want.Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines