This change is required to migrate existing tests to run QEMU worker tests on GitHub Actions.
GitHub hosted runners can't run the ping command: https://github.com/actions/runner-images/issues/1519 by design. If we still intend to use ping, the solution would be running QEMU worker tests on self-hosted runners which allow ICMP packets
This change is intended to be backwards compatible and shouldn't affect tests running on Jenkins or for the autokit
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
This change is required to migrate existing tests to run QEMU worker tests on GitHub Actions. GitHub hosted runners can't run the
ping
command: https://github.com/actions/runner-images/issues/1519 by design. If we still intend to useping
, the solution would be running QEMU worker tests on self-hosted runners which allow ICMP packetsThis change is intended to be backwards compatible and shouldn't affect tests running on Jenkins or for the autokit
Change-type: patch Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines