search

balena-os / meta-balena

A collection of Yocto layers used to build balenaOS images
https://www.balena.io/os
968 stars 115 forks source link

patch: Add Test Suite specific config for GHA #3415

Closed vipulgupta2048 closed 3 months ago

vipulgupta2048 commented 5 months ago

To parallelize test runs on GHA, having separate test suite-specific configs available would be the way to go. This change is backward compatible with the current Jenkins configuration.

Reasoning: Each matrix job of Leviathan will run one test suite using this one config modification made in this PR. This will allow us only to retry a single test suite and not all 3 again.

Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com

klutchell commented 5 months ago

LGTM

vipulgupta2048 commented 4 months ago

This PR will be blocking merge now for https://github.com/balena-os/balena-yocto-scripts/pull/329 Updating the milestone @klutchell @rcooke-warwick

vipulgupta2048 commented 4 months ago

@rcooke-warwick you mentioned once that we are facing an issue with hardcoded image paths as well in the config.js. Did we resolve that issue or still pending?

rcooke-warwick commented 3 months ago

@vipulgupta2048 it was a minor issue - basically I stead of hard coding the name of the image maybe we should do it as an env var also - that way if we need to use something other than the balena.img we can

vipulgupta2048 commented 3 months ago

@rcooke-warwick how about an env var with a default?