At this moment the kexec initrd script is skipped when ROOTFS_DIR is not defined or if the new rootfs is mounted, but does not contain a kernel image in the expected place. This is undesirable as we assume this is the last script executed by the balena bootloader.
This patch makes the kexec script always execute in the balena bootloader and makes it fail hard in unexpected states, which means the script is always an exit point for the balena bootloader, whether the actual kexec call succeeds or not.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
At this moment the kexec initrd script is skipped when
ROOTFS_DIR
is not defined or if the new rootfs is mounted, but does not contain a kernel image in the expected place. This is undesirable as we assume this is the last script executed by the balena bootloader.This patch makes the kexec script always execute in the balena bootloader and makes it fail hard in unexpected states, which means the script is always an exit point for the balena bootloader, whether the actual kexec call succeeds or not.
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines