Init hooks specify an *_enabled function that determines whether or not the hook is skipped during boot. Hooks are run by the "init" script, shipped as part of the initramfs-framework poky recipe.
Several conditions were checked in the cryptsetup-efi-tpm enablement function, some of which could cause the hook to be improperly skipped.
Force the hook to run when in secure boot user mode, as we want any failure in the hook's run function to be detected and abort the boot.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
Init hooks specify an *_enabled function that determines whether or not the hook is skipped during boot. Hooks are run by the "init" script, shipped as part of the initramfs-framework poky recipe.
Several conditions were checked in the cryptsetup-efi-tpm enablement function, some of which could cause the hook to be improperly skipped.
Force the hook to run when in secure boot user mode, as we want any failure in the hook's run function to be detected and abort the boot.
Change-type: patch
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines