balena-os / meta-balena

A collection of Yocto layers used to build balenaOS images
https://www.balena.io/os
968 stars 115 forks source link

tests: os: connectivity: test redsocks config via supervisor api #3488

Open rcooke-warwick opened 2 months ago

rcooke-warwick commented 2 months ago

A regression was introduced with supervisor 16.4.0 that broke proxy configuration via the supervisor API, when using the noProxy parameter. This commit adds a test to configure via the supervisor API, hoping to catch issues such as these

Change-type: patch

This test passes on 5.3.15 locally (before supervisor 16.4.0 , and fails on 5.4.0 (after supervisor 16.4.0) due to the redsocks.conf incorrectly having a noProxy field added to it, resulting in this:

Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: unexpected char
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: unclosed section
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: stale key_token
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: stale value_token
Aug 08 13:27:59 8f94e56 systemd[1]: redsocks.service: Main process exited, code=exited, status=1/FAILURE
Aug 08 13:27:59 8f94e56 systemd[1]: redsocks.service: Failed with result 'exit-code'. 

Contributor checklist

Reviewer Guidelines

github-actions[bot] commented 2 months ago

Website deployed to CF Pages, 👀 preview link https://fc6e7d49.balena-os.pages.dev

pipex commented 2 months ago

@rcooke-warwick the commit/PR body mention a noHup configuration when I think you mean noProxy