A regression was introduced with supervisor 16.4.0 that broke proxy configuration via the supervisor API, when using the noProxy parameter. This commit adds a test to configure via the supervisor API, hoping to catch issues such as these
Change-type: patch
This test passes on 5.3.15 locally (before supervisor 16.4.0 , and fails on 5.4.0 (after supervisor 16.4.0) due to the redsocks.conf incorrectly having a noProxy field added to it, resulting in this:
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: unexpected char
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: unclosed section
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: stale key_token
Aug 08 13:27:59 8f94e56 redsocks[5915]: file parsing error at line 13: stale value_token
Aug 08 13:27:59 8f94e56 systemd[1]: redsocks.service: Main process exited, code=exited, status=1/FAILURE
Aug 08 13:27:59 8f94e56 systemd[1]: redsocks.service: Failed with result 'exit-code'.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
A regression was introduced with supervisor 16.4.0 that broke proxy configuration via the supervisor API, when using the
noProxy
parameter. This commit adds a test to configure via the supervisor API, hoping to catch issues such as theseChange-type: patch
This test passes on 5.3.15 locally (before supervisor 16.4.0 , and fails on 5.4.0 (after supervisor 16.4.0) due to the
redsocks.conf
incorrectly having anoProxy
field added to it, resulting in this:Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines