search

balena-os / resin-device-toolbox

[DEPRECATED] The official Resin Device Toolbox CLI for resinOS
Apache License 2.0
14 stars 3 forks source link

Implement rdt join command to promote a resinOS device to resin.io #72

Closed jbaldwinroberts closed 7 years ago

jbaldwinroberts commented 7 years ago

The command suggested for implementation is:

rdt join [deviceIp | hostname]

Should the optional [deviceIp | hostname] not be supplied, then the join command will search for all resinOS devices currently available and request that the user selects one (similarly to other rdt commands, such as ssh).

once a device is selected rdt will SSH into the device and run the `./resin-provisioner' binary, passing CLI input/output back to the user

More info : https://github.com/resin-io/hq/pull/451

lekkas commented 7 years ago

@shaunmulligan @josephroberts have we decided on a name for this command in the recent product calls? rdt join, rdt promote and rdt realm have been suggested in the past.

jbaldwinroberts commented 7 years ago

@lekkas not that I am aware of, my vote would be for rdt promote

lekkas commented 7 years ago

Thank you @josephroberts , yeah it looks like it's still tbd, I think it's fine not to block on this and use a placeholder for now, pinging @alisondavis17 and @alexandrosm as well ^

alexandrosm commented 7 years ago

the latest thing we ended up with was "rdt promote", let's go with that for now.

--

Alexandros Marinos

Founder & CEO, Resin.io

+1 206-637-5498

@alexandrosm

On Mon, Feb 20, 2017 at 6:55 AM, Kostas Lekkas notifications@github.com wrote:

Thank you @josephroberts https://github.com/josephroberts , yeah it looks like it's still tbd, I think it's fine not to block on this and use the rdt join placeholder for now, pinging @alisondavis17 https://github.com/alisondavis17 and @alexandrosm https://github.com/alexandrosm as well ^

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/resin-os/resin-device-toolbox/issues/72#issuecomment-281099733, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLUCCi1pppAu2JV9H7e1QYHGJBnkRmKks5realugaJpZM4MDIlW .

jbaldwinroberts commented 7 years ago

missed off the interactive command that has been added in the latest version of resin-provisioner and did not notice until I ran a full end-to-end test.