balena-os / resin-device-toolbox

[DEPRECATED] The official Resin Device Toolbox CLI for resinOS
Apache License 2.0
14 stars 3 forks source link

I can't connect to unprotected networks with the configurator #8

Open lekkas opened 7 years ago

lekkas commented 7 years ago

Connects to https://github.com/resin-io-playground/resin-toolbox/issues/47

jviotti commented 7 years ago

Can you elaborate a bit more on this? What does "unprotected" network means? Omitting a network key yields an error? If so, what error?

shaunmulligan commented 7 years ago

@jviotti he means "unprotected" in the sense that the wifi has no password. Now the issue here is that it's not as easy as setting an empty string for psk, for NM connection files, you need to remove the enire [wifi-security] section and a few other things, so we need to think about a good way to do this :(

jviotti commented 7 years ago

I see. I guess the only option is to introduce a "checkbox" for "Does your network needs a password?", and conditionally apply the whole thing like we were doing for ethernet and wifi in the ResinOS v1 reconfix example.

shaunmulligan commented 7 years ago

@jviotti yeah, that sounds like a good approach to me. In the CLI it does require the user to go through another step, but I dont see an easy way around that right now.