search

baler-collaboration / baler

Repository of Baler, a machine learning based data compression tool
https://github.com/baler-collaboration/baler.github.io
Apache License 2.0
33 stars 31 forks source link

Global flag for error-bound compression #295

Closed urania277 closed 1 year ago

urania277 commented 1 year ago

Hi @singh96aman,

we can't figure out how to make error-bound compression optional using the flags below.

https://github.com/baler-collaboration/baler/blob/c11e6fe7e424c9f3ce605cba0886305cf0862aa8/workspaces/CMS_workspace/CMS_project_v1/config/CMS_project_v1_config.py#L16C37-L16C37

Could we have a global true/false flag for turning this off if the user doesn't wish to use it?

Thanks!

singh96aman commented 1 year ago

We've a global true/false flag (here) and (here).

It's been set to true which in hindsight seems wrong. I'll raise a PR to make this false by default

fritjof-b commented 1 year ago

This is complete with #294