balidani / tinyctf-platform

Yet another CTF platform
MIT License
146 stars 58 forks source link

Implemented some features #10

Open gehaxelt opened 8 years ago

gehaxelt commented 8 years ago

Hi, I've implemented some featuers:

That are more or less the changes I made for our CTF.

All the best, gehaxelt

gehaxelt commented 8 years ago

PS: Closes #9 #8 #6

yeuchimse commented 8 years ago

In my opinion, CSRF protection is not needed, and in your CTF it was inconvenient for my team. Normally in a CTF, you open the challenges page, click on some challenges to open them in new tabs, then open each tab, solve the challenge and submit the flag. With your CSRF protection, once you open the second tab, you could not submit the flag for the challenge in the first tab, because the CSRF token has been changed and is no longer valid.

gehaxelt commented 8 years ago

Hi @yeuchimse Thanks for the feedback! I've pushed a fix for this by providing a enable_csrf_protection configuration option :)

yeuchimse commented 8 years ago

Nice fix :D I though you would remove that protection, but giving an option to disable it seems better for all people :D

balidani commented 8 years ago

Hi all,

I'm still here, but a bit busy at the moment. I'll get back to these PRs later, and hopefully merge them. Thanks for your interest in the project.