balinterdi / ember-cli-star-rating

An Ember CLI addon for using stars to manage ratings
MIT License
26 stars 5 forks source link

Provide off-the-shelf components for popular icon libraries #10

Open balinterdi opened 8 years ago

balinterdi commented 8 years ago

There would be a star-rating-glyph, star-rating-fa, and a few others. This way, the user wouldn't even have to provide the classes for the desired icon library.

The idea was brought up by César in #8 , so see the discussion there.

cesarizu commented 8 years ago

This are some of the most used icon fonts:

Font awesome

<i class="fa fa-fw fa-star"></i>
<i class="fa fa-fw fa-star-o"></i>

Icomoon

<i class="icomoon icon-star-3"></i>
<i class="icomoon icon-star"></i>

These can change depending if you use a custom build.

Ion Icons

<i class="ionicons ion-android-star"></i>
<i class="ionicons ion-android-star-outline"></i>

Material Icons

<i class="material-icons">star</i>
<i class="material-icons">star_border</i>

This needs the icon in the content, so a couple new properties, maybe fullText and emptyText would be needed.

Foundation font icons

<i class="fi-star"></i>
<i class="fi-star empty"></i>

No empty star for foundation but the class empty could perhaps be used to style it with a different color.

I'm planning on creating the components for these, does it look right?

balinterdi commented 8 years ago

Thank you for the research. I'd add off-the-shelf components for glyphicons, font awesome, icomoon and ion icons as there are the ones where simply passing class names does the job.

I'd let the user use the block form of the component where more work is needed (material icons and foundation font icons).

What do you think?

balinterdi commented 6 years ago

Do #19 first.