Consider using protocol buffers

baljeetverma / android-notifier

Automatically exported from code.google.com/p/android-notifier

0 stars 0 forks source link

Consider using protocol buffers #131

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Please, consider using google protocol buffers to allow easier evolution and 
implementation.

Original issue reported on code.google.com by lehph...@gmail.com on 12 Sep 2010 at 9:48

GoogleCodeExporter commented 9 years ago

I'm attaching a proto file specifying message formats for notifications and 
commands. Message delimitation and encryption could be handled sending two 
proto varint32 before each message, one specifying the length of the protobuf 
message and another specifying if the message is encrypted.

Original comment by lehph...@gmail.com on 22 Sep 2010 at 4:02

Added labels: Component-Communication, Maintainability, OpSys-Android, OpSys-Desktop, Type-Enhancement
Removed labels: Type-Defect

Attachments:

android-notifier.proto

GoogleCodeExporter commented 9 years ago

Ok, some perliminary comments on the proto file:
- device ID should be a fixed32
- notification ID should be a fixed32
- use a MessageSet for notification-type-specific and command-type-specific 
data (keep description since it's generic, but the battery data should go 
there, for instance - same about caller ID data

Original comment by rdamazio@gmail.com on 24 Sep 2010 at 6:03

GoogleCodeExporter commented 9 years ago

What is MessageSet? You mean message_set_wire_format?
I think description should be required and we could add a notification image 
and title to allow customization by third-party apps and sending contact 
picture on phone calls and sms messages.

Original comment by lehph...@gmail.com on 24 Sep 2010 at 6:15

GoogleCodeExporter commented 9 years ago

Here is the updated proto file: 
http://code.google.com/p/android-notifier/source/browse/trunk/MultiDroidNotifier
/src/main/protobuf/android-notifier.proto

Original comment by lehph...@gmail.com on 28 Sep 2010 at 2:47

Changed state: Started

GoogleCodeExporter commented 9 years ago

Committed to svn protobuf parser and a parser (MultiNotificationParser) that 
knows how to handle text and protobuf messages.

Original comment by lehph...@gmail.com on 30 Sep 2010 at 3:35

GoogleCodeExporter commented 9 years ago

Leandro, will you be so kind as to add the Mac binary for protoc with the 
appropriate rule to use it instead of the windows version when on a mac? It's 
attached.
I can also generate the linux version if you wish.

Original comment by rdamazio@gmail.com on 30 Sep 2010 at 5:21

Attachments:

protoc

GoogleCodeExporter commented 9 years ago

Committed to svn, if it's easy for you to compile linux protoc, please do. I 
can compile it tonight if you don't.

Original comment by lehph...@gmail.com on 30 Sep 2010 at 5:54

GoogleCodeExporter commented 9 years ago

Just to let you know, ProtobufNotificationParserTest has an implementation of 
writing a notification using CodedOutputStream that could be used in the 
android app.

Original comment by lehph...@gmail.com on 30 Sep 2010 at 8:21

GoogleCodeExporter commented 9 years ago

Taking over lehphyro's issues.

Original comment by rdamazio@gmail.com on 11 Jan 2011 at 4:31