search

ballaswag / guppyscreen

A native Touch UI for 3D Printers running Klipper/Moonraker.
GNU General Public License v3.0
231 stars 23 forks source link

Screen brightness #44

Open natsgo opened 8 months ago

natsgo commented 8 months ago

Hello,

First of all great work. Everything is easier vs the stock Creality UI.

I am running a KE and the screen brightness is on 100%. I hope you can add a setting to adust screen brightness.

Thanks.

ballaswag commented 8 months ago

Brightness adjustment is one of my todos.

natsgo commented 8 months ago

Thank you sir.

consp commented 5 months ago

Old issue but since I added it for the ff5m: https://github.com/ballaswag/guppyscreen/commit/601736d5639993cf55cb3b6632d0eafa0c6fea4c it can be used as a reference.

The ff5m needs special ioctl's to alter the brightness so it might/might not be portable but the general idea is the same.

We did ioctl and added it to fbdev as a patch since that's where all ioctls happen now. Depending on how well the systems implement brightness: it's already a mess on laptop's and I would guess it's all custom ioctl's for embedded systems and heavily depends on the kernel display driver. If it uses a sunxi device as a bonus it also depends on the kernel version used since they changed the ioctl's in the 5.x vs the 4.x.