ballaswag / guppyscreen

A native Touch UI for 3D Printers running Klipper/Moonraker.
GNU General Public License v3.0
166 stars 14 forks source link

Add configuration option to disable spoolman integration #61

Open adec opened 1 month ago

adec commented 1 month ago

New printer configuration option "disable_spoolman" has been added to allow the spoolman integration to be disabled on a per-printer basis. Setting this option to true only disables the guppyscreen integration with spoolman and does not affect Moonraker. This is useful if incompatibility with a particular spoolman version prevents guppyscreen from initialising (such as issue #49).

georgiy364 commented 1 month ago

Hello!

Can you please help and explain how to install it? You're gonna be a big help to me I deleted previous Guppy and installed your using this code sh -c "$(wget --no-check-certificate -qO - https://raw.githubusercontent.com/ballaswag/guppyscreen/e4fdf4e6224de7896c8fc96ef5b7b9640f322533/installer.sh)" Is that right? And my screen is still not working. Is there anything else I need to do?

adec commented 1 month ago

Hi @georgiy364,

Unfortunately the installation script will just pull down and install the latest release version not the version with this fix. Let me see if I can make the compiled version of the guppyscreen binary that you can install over the release version.

Just double-checking, are you using spoolman? If so, you may be able to resolve the issue by making sure that all your filament entries in spool man have the vendor, material type, etc filled in.

I'm working on a proper fix for the issue (this was pull request was really to buy some time to fix things properly).

georgiy364 commented 1 month ago

Thank you a lot!

Yes, the issue was with the spoolman and your advice works perfectly! Appreciate

ballaswag commented 1 month ago

PR looks good overall. Even though you figured out the underlying issue relating to not checking for optional fields, it's nice to have the ability to disable spoolman completely.