search

ballercat / jambox

CLI tool for recording and playing back networks requests for node & Frontend Apps.
MIT License
11 stars 2 forks source link

Update local certs to expire in 3000 days #37

Closed hamlim closed 1 year ago

hamlim commented 1 year ago

I ran the following command locally:

openssl req -x509 -new -nodes -keyout testCA.key -sha256 -days 3000 -out testCA.pem -subj '/CN=Mockttp Testing CA - DO NOT TRUST'

(note the 3000 for the days argument!)

which I found from these docs: https://github.com/httptoolkit/mockttp/blob/main/docs/setup.md#generating-a-certificate

Not sure if this is the same way that the certs were originally created, but the output seems to be the same.

New endDate: notAfter=Dec 26 19:34:32 2031 GMT (found via running: openssl x509 -enddate -noout -in testCA.pem)

Fixes: #36

ballercat commented 1 year ago

@hamlim

Sonar breaks on forked PRs see https://community.sonarsource.com/t/code-analysis-on-pull-request-from-forked-repository-with-github-actions/43986/7

Are you able to clone/open a non forked PR? I can bypass if it's too much of a hassle otherwise. Thanks

hamlim commented 1 year ago

@ballercat looks like I don't have permission to push branches up to the repo, GH is forcing me to fork the repo to open a PR 😢

ballercat commented 1 year ago

Aight np, tests pass anyway.