Closed DanielRuf closed 5 years ago
And finally we found a fialing build thanks to the addition of Node.js 10.
https://travis-ci.com/ballercat/walt/jobs/151169482
node-sass
has to be upgraded.
Seems we caught another issue. Can someone take a closer look?
Thanks for this.
I'm taking a look at the test failure now.
So I get a related but different error locally, which is odd BUT the issue is with string decoding and thememory.grow()
instruction inside the statics spec.
It's also verified by this comment on emscripten issues board https://github.com/kripken/emscripten/issues/6747#issuecomment-400081465
Turns out, growing a memory replaces the internal buffer inside the memory instance. I'm not sure this is documented anywhere either.
Also, shouldn't node 10 be LTS already? If it's close I'd rather just test against it and not both 8 & 10. I'd like to keep these test pipelines quick.
10 should become LTS this month, see https://github.com/nodejs/Release/blob/master/README.md
But there are always 2 LTS releases / branches and 8 EOL will take a while.
Pull Request Test Coverage Report for Build 181
💛 - Coveralls