search

ballerina-platform / ballerina-lang

The Ballerina Programming Language
https://ballerina.io/
Apache License 2.0
3.58k stars 737 forks source link

[Bug]: Inconsistency between `org` field validation in CLI and central #39723

Open gayaldassanayake opened 1 year ago

gayaldassanayake commented 1 year ago

Description

According to ballerina central, "Organization name can only contain alphanumeric values with lower case letters and cannot start with numeric values".

However ballerina toml org field validation regex is ^[a-zA-Z0-9_]*$, which allows any string consisting of zero or more alphanumeric characters or underscores. Note that both upper and lower cases are allowed.

Similarly in the CLI commands (eg- pull), we have a validation identical to the toml validation in ProjectUtils.validateOrgName method.

This can be an issue since the user will not realize that the org name is incompatible with the central validation until he tries to create an org in the central with the same org name as the repo.

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Other Area

Related issue(s) (optional)

https://github.com/ballerina-platform/ballerina-lang/issues/39721

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

ShammiL commented 10 months ago

Following https://github.com/ballerina-platform/ballerina-spec/issues/791#issuecomment-858593020, the following validations were done in Ballerina.toml.

The same validations should also be enabled on Central. This improvement is tracked in https://github.com/wso2-enterprise/ballerina-registry/issues/1201

github-actions[bot] commented 10 months ago

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Thevakumar-Luheerathan commented 4 months ago

This issue can not addressed from the Central side because of org name limitation in Asgardeo. Currently, we are having an issue when we create new packages with templates and publish them. Here, the org name is derived from the OS user account(user account name can have space. These spaces are replaced with an underscore.)