ballerina-platform / ballerina-lang

The Ballerina Programming Language
https://ballerina.io/
Apache License 2.0
3.54k stars 733 forks source link

[2201.9.0] Suppress the warnings from imports #42613

Closed Thevakumar-Luheerathan closed 2 weeks ago

Thevakumar-Luheerathan commented 3 weeks ago

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #32985

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

sameerajayasoma commented 3 weeks ago

The compiler option --showAllWarnings is too generic. We need an option that shows only the dependent package warnings, right?

We already show current package warnings. So --showAllWarnings doesn't make sense.

azinneera commented 3 weeks ago

The compiler option --showAllWarnings is too generic. We need an option that shows only the dependent package warnings, right?

We already show current package warnings. So --showAllWarnings doesn't make sense.

Considering the above comment and @nipunayf's suggestion to hide INFO and HINT diagnostics also by default, how about --show-dependency-diagnostics?

Thevakumar-Luheerathan commented 3 weeks ago

We need an option that shows only the dependent package warnings

It means, that when the user gives bal build --<option-we-introduce>, should we print only the diagnostics from the dependency package? shouldn't we print the current package diagnostics?

I thought that we don't print all these dependency package diagnostics. with the flag, we print all the diagnostics both from the current package and the dependency packages.