[2201.8.x] Revise the definition API of the `TypeReferenceTypeSymbol` to exclude searching for virtual symbols in the scope - Githubissues

ballerina-platform / ballerina-lang

The Ballerina Programming Language

https://ballerina.io/

Apache License 2.0

3.54k stars 733 forks source link

[2201.8.x] Revise the definition API of the `TypeReferenceTypeSymbol` to exclude searching for virtual symbols in the scope #42626

Open nipunayf opened 2 weeks ago

nipunayf commented 2 weeks ago

Purpose

$title as virtual symbols are not stored in the scope.

Fixes #42454

Approach

The current approach ensures that the definition API of the type references does not search for virtual symbols in the current scope.

Remarks

Although this PR fixed the semantic API issue, the tsymbol set for narrowed type symbols remains invalid, which is being tracked separately.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests
- [x] Unit Tests
- [ ] Spec Conformance Tests
- [ ] Integration Tests
- [ ] Ballerina By Example Tests
[ ] Increased Test Coverage
[ ] Added necessary documentation
- [ ] API documentation
- [ ] Module documentation in Module.md files
- [ ] Ballerina By Examples

github-actions[bot] commented 10 hours ago

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.