Tooling support for SQL connectors

niveathika commented 3 years ago

Description: Add Tooling support for SQL connectors,

Following tooling support must be implemented,

niveathika commented 3 years ago

Diagnostics

[x] Improve 'cannot infer type for parameter 'rowType' error for query(). This needs to include to add either rowType param or not ignore the return
[x] Improve 'cannot infer type for parameter 'rowType' error for queryRow(). Here we need to validate that this of any data type. As of now, the compiler allows stream.
[x] Each OutParameter get method to validate typedescription param at compile time.
[x] Need to validate negative values for connection pool configs.
[x] ~batchExecute sqlQueries param needs to be validated for an empty array.~ This is not possible at runtime.

Code Completions

[ ] ~Add completion for parameterised query param. ( This was discussed and not implemented as we are not doing completions for any other data types.)~
[x] Sort SQL remote function based on LHS (https://github.com/ballerina-platform/ballerina-lang/issues/33672)

Code Action

[x] ~OutParmeter suggests a supported type description based on the object type.~ This is not needed after the type description is made defaultable by making it inferred from an assignment.

Hover

niveathika commented 3 years ago

The updated tooling actions are based on 1.1.0 changes,

Diagnostics

[x] Improve inferring error for query(). Current: cannot infer type for parameter 'rowType'(BCE3934) Hint: Parameter 'rowType' should be explicitly defined when the return data is ignored.
[x] Improve inferring error for queryRow(). Current: incompatible type for parameter 'returnType' with inferred typedesc value: expected 'typedesc\', found 'typedesc'(BCE3931) Hint: Parameter 'returnType' should be explicitly defined when the return data is ignored.
[x] Improve inferring error for OutParameter. Current: incompatible type for parameter 'returnType' with inferred typedesc value: expected 'typedesc\', found 'typedesc'(BCE3931) Hint: Parameter 'typeDesc' should be explicitly defined when the return data is ignored.
[x] Each OutParameter get method to validate type description param at compile time.
- Validate for explicity defined param (Done)
- Validate for inferred typeDesc param
[x] Need to validate negative values for connection pool configs.
- Validate for variable assignments (Done)
- Validate for inline definitions at SQL connectors

Code Completions

Hover

niveathika commented 2 years ago

Closing this as the remaining tooling support must be enabled from the LS code and those are tracked in seperate issues.

ballerina-platform / ballerina-library