ballerina-platform / ballerina-library

The Ballerina Library
https://ballerina.io/learn/api-docs/ballerina/
Apache License 2.0
137 stars 65 forks source link

Remove unused else block in client streaming receive function #2442

Open dilanSachi opened 2 years ago

dilanSachi commented 2 years ago

Description: In client streaming, when the server is sending Empty messages, the client's receive method currently looks as follows.

isolated remote function receive() returns grpc:Error? {
    var response = check self.sClient->receive();
    if response is () {
        return response;
    } else {
        _ = response;
    }
}

The else block is not needed and we need to remove it.

AnsarMahir commented 1 week ago

@keizer619 is this still valid? If yes, Can i work on this ??