ballerina-platform / ballerina-library

The Ballerina Library
https://ballerina.io/learn/api-docs/ballerina/
Apache License 2.0
137 stars 59 forks source link

Extra line is included in generated ballerina source in grpc tool #3953

Open keizer619 opened 1 year ago

keizer619 commented 1 year ago

Description: Extra line is included in generated ballerina source in grpc tool (sample source)

angelinagovada commented 1 year ago

Hello, Can I pick this up?

Thanks

dilanSachi commented 1 year ago

👋 Welcome, @angelinagovada ! 🚀

We're thrilled to have you join the Ballerina Lang community! Whether you're a seasoned developer or just starting your journey with Ballerina, we value your contributions and look forward to collaborating with you. To help you get started, here are some essential resources:

  1. Understanding Ballerina Platform: Learn what Ballerina is all about: Ballerina Platform
  2. How to Contribute: Read our contributing guidelines to understand how you can contribute effectively: Contribution Guide
  3. Contributing to the Ballerina library: If you're interested in contributing to our library, here are the guidelines: Library Contribution Guide
  4. Learn Ballerina: If you're new to Ballerina or want to enhance your skills, our official website offers a wealth of learning resources: Learn Ballerina
  5. Get Help and Connect: Join our Discord community to chat with fellow Ballerina enthusiasts and get assistance: Ballerina Discord

Remember, no contribution is too small, and your feedback is invaluable. Feel free to ask questions, propose ideas, or report issues. Together, we can make Ballerina even better! Happy coding! 🎉

dilanSachi commented 1 year ago

@angelinagovada Let me give you some context regarding this specific issue.

In Ballerina gRPC, we use the protoc-tool to generate the ballerina files needed for the gRPC client and service. In the current generated files, there are 2 extra lines getting added [1]. We need only 1 newline.

This fix needs to be done in the protoc-tool.

Also, if you want learn about gRPC and the protoc-tool you can follow these.

[1] https://github.com/ballerina-platform/protoc-tools/blob/main/tooling-tests/src/test/resources/test-src/generated-sources/tool_test_bidirectional_1/helloWorldString_pb.bal

keizer619 commented 10 months ago

@angelinagovada Are you working on this?