ballerina-platform / ballerina-library

The Ballerina Library
https://ballerina.io/learn/api-docs/ballerina/
Apache License 2.0
137 stars 58 forks source link

Copybook fromBytes() panic when invalid value provided as a decimal value #6982

Closed MohamedSabthar closed 2 weeks ago

MohamedSabthar commented 2 weeks ago

Description: The fromBytes() API internally uses the decimal:fromString() method which is currently panics for invalid string instead of returning an error. Refer https://github.com/ballerina-platform/ballerina-lang/issues/43377 for lang issue.

Steps to reproduce:

Affected Versions:

OS, DB, other environment details and versions:

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

MohamedSabthar commented 2 weeks ago

As a workaround we need to manually call the trap when calling decimal:fromString() method.

github-actions[bot] commented 2 weeks ago

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.