search

ballerina-platform / ballerina-spec

Ballerina Language and Platform Specifications
Other
168 stars 53 forks source link

Add missing viewport details in lang spec pages #1317

Open sm1990 opened 1 month ago

sm1990 commented 1 month ago

Purpose

$subject Fixes https://github.com/ballerina-platform/ballerina-dev-website/issues/9147

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

sm1990 commented 1 month ago

Presentational stuff like this should go in spec.xsl not spec.html.

I have updated the spec.xsl

sm1990 commented 1 month ago

This is a tiny nit, but please move the added line one line down, so it's next to the other meta tag.

Sorry my bad. Committed the wrong file. Could you please review again.

sm1990 commented 1 month ago

I didn't make myself clear in the previous comment. I just want the new <meta> tag, which you added before the <title> tag to be moved so that it is after the <title> tag, and next to the the <meta charset tag.

I have fixed the meta tag order. Could you please review again.