Fixing closing/reopening files

[payne911]

Many things were causing issues related to closing and reopening files (fixes #344)

Core changes are (I could be wrong on any of this, so please be careful when you review this... you can follow my investigation and train of thought in #344):

• (https://github.com/ballerina-platform/lsp4intellij/pull/345/commits/9b2b0557c93dbdb8cbe2b7a6b09925286a44d663) LSPFileEventManager#fileRenamed was sending duplicate didChangeWatchedFiles notifications.
• (https://github.com/ballerina-platform/lsp4intellij/pull/345/commits/bc9c5ea31c2b0735f3a3620d64b72e58198d24a5) EditorEventManagerBase#unregisterManager was not appropriately cleaning up the Set<EditorEventManager>.
  • This was causing DocumentEventManager#documentClosed to not hit the appropriate code path because EditorEventManagerBase.managersForUri was not appropriately maintained. (In turns causing the documentOpened to also be broken.)
• (https://github.com/ballerina-platform/lsp4intellij/pull/345/commits/34b29ee729c85d59b972313f5480c305785228d8) EditorEventManager's constructor was erroneously trying to reuse a previous DocumentEventManager.
  • This was causing calls to documentChanged to be aborted because the associated editor had been disposed.
  • This means that DocumentEventManager's uriToDocumentEventManager was not useful anymore, thus all the related code was removed.

This PR also fixes a bunch of misc stuff I encountered while digging around:

• unused import
• indent
• final properties
• wrong logger
• implicit calls
• typo
• JavaDoc
• duplicated logic
• nullabilities and associated null-checks

The original issue (#344) also points out many things which would still be worth investigating. I highly encourage the maintainers to closely read through it.

[payne911]

@cpedlar-syn feel free to help reviewing this since it touches some logic introduced by you in #313

[payne911]

Getting a review from @Trias (author of #241) would probably be even more relevant.

[cpedlar-syn]

@cpedlar-syn feel free to help reviewing this since it touches some logic introduced by you in #313

The part that I had touched in the past looks good and a lot of the cleanup looks good. I can't comment on the other parts that I'm not as familiar with.

👍

[github-actions[bot]]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[payne911]

3 weeks without activity is a very short window to automatically decide that a PR should be discarded. It's not like this repo is seeing an incredible influx of contributions: having them pile up could be good to indicate to others that there is indeed interest in improving it.

On my side, I'm certainly noting that the hours it took me to debug and fix this will simply go down the drain. That's definitely demoralizing. :( I now wonder how many other contributions were simply wasted due to this odd policy.

[NipunaRanasinghe]

@payne911, we appreciate your contribution and apologize for the delay in getting back to you. Unfortunately, we've been occupied with other priorities recently but the good news is, we have plans to revive this project as we'll be working on a new Ballerina language plugin based on this client.

Regarding the stale policy, it's a platform-wide initiative, but we understand your valid concerns. I'll explore the possibility of disabling the stale policy for this repository(at least until we revive this project), to ensure that valuable contributions don't go unnoticed.

Thank you for your understanding and looking forward to your continued contributions :)