search

ballerina-platform / nballerina

Ballerina compiler that generates native executables.
https://ballerina.io/
Apache License 2.0
138 stars 46 forks source link

Fix nightly builds #1101

Open manuranga opened 1 year ago

manuranga commented 1 year ago
Screenshot 2022-10-21 at 1 23 08 PM
manuranga commented 1 year ago

Looks like ballerina-distribution/daily-build-2201.0.x.yml is deleted and ballerina-distribution/daily-build-2201.1.x.yml has been failing for a month. So no point of having these at our end.

@keizer619 Please provide us a list of ballerina-distribution workflows to rely on.

In absence of the correct versions, these two builds are currently running on some random build form dist, which happens to be ballerina-2201.2.2-SNAPSHOT-swan-lake-linux-x64, with following error.

[fail] typeTests#'int.typetest#6':

something impossible happened (unreached in semTypeFromSexpr for sexpr:["!",["int",[8,8]]])

    at wso2.nballerina.comm.err.0:impossible(err.bal:37)
    wso2.nballerina.types.sexpr.0:semTypeFromSexpr(convert.bal:64)
    wso2.nballerina.types.sexpr.0:semTypeFromSexpr(convert.bal:39)
    wso2.nballerina.types.sexpr$test.0.tests.typeTest:typeTests(tests/typeTest.bal:51)

Sent a PR for this #1102.

Attempting to reproduce this error locally, I tested with a ballerina-2201.2.2-SNAPSHOT-swan-lake but it is giving me a different (more severe) error.

https://github.com/ballerina-platform/ballerina-lang/issues/38339

I couldn't test the PR locally due to above, when I tried to test it in GitHub actions, it gave yet another error: ERROR [tests/exprBinaryDiv.bal:(29:55,29:74)] '9223372036854775808' is out of range for 'int'

manuranga commented 1 year ago

Had a chat with @keizer619 We decided test nBallerina during daily full build of jBallerina. Please add following steps to the build

git clone --depth=1 git@github.com:ballerina-platform/nballerina.git
(cd nballerina/compiler && path/to/newly/created/bal test)

I will send a PR to remove Validate on jBallerina 2201.0.x nightly Validate on jBallerina 2201.1.x nightly.

I am still planing to keep Validate on jBallerina nightly as a final check, but with this approach it should never fail.