Closed liorzam closed 1 month ago
Latest commit: 1430237438461e9ba8bbf07a4f4713e85c5e47fc
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[!WARNING]
Rate Limit Exceeded
@liorzam has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 46 minutes and 50 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 595627f3f930ff123c2c46f57456d33d3cb5e95d and 1430237438461e9ba8bbf07a4f4713e85c5e47fc.
The changes enhance the workflows-service
by updating environment variable handling, adding new scripts for Docker and bcrypt salt generation, and restructuring the environment variable schema. These updates improve the setup process, ensure better compatibility across different operating systems, and streamline environment configuration management.
File/Directory | Change Summary |
---|---|
services/workflows-service/.env.example |
Enclosed HASHING_KEY_SECRET value in double quotes. |
services/workflows-service/package.json |
Added docker:db:down script and updated setup script to include it. |
services/workflows-service/prisma/data-migrations |
Updated subproject commit hash. |
services/workflows-service/src/env.ts |
Restructured server environment variable definition using serverEnvSchema . |
scripts/hashkey.sh |
Bash script to read, adjust, and append secret values to environment files. |
scripts/generate-salt.sh |
New script to generate bcrypt salt and set HASHING_KEY_SECRET based on the operating system. |
scripts/init.js |
Added function call to run generate-salt.sh script. |
services/workflows-service/scripts/generate-salt.ts |
New TypeScript file to generate bcrypt salt using Node.js and set HASHING_KEY_SECRET . |
In the code's embrace, secrets now reside,
Wrapped in quotes, no place to hide.
Scripts to Docker dance, databases sway,
With salts and hashes, they pave the way.
A rabbit's touch, so soft and bright,
Guides the changes, day and night.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
HASHING_KEY_SECRET
based on the operating system.Improvements
.env.example
to encloseHASHING_KEY_SECRET
in double quotes.Chores