Closed liorzam closed 1 month ago
Latest commit: f8340ac0f06c72fdd3aa9112f7e970ed1cf532ca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The recent updates primarily focus on refining the workflows service scripts and alert service. Key changes include type adjustments for alert definitions, variable renaming for clarity, and restructuring how counterparty IDs are managed. Additionally, the alert service now uses a nested property for monitoring types. These modifications aim to enhance code readability, maintainability, and functionality.
Files | Change Summaries |
---|---|
.../scripts/alerts/generate-alerts.ts |
Adjusted parameter types, renamed variables, and updated variable assignments for clarity and type flexibility. |
.../scripts/alerts/generate-transactions.ts |
Split counterparty IDs into two arrays (businessCounterparties and endUserCounterparties ) and updated the function to return these arrays. |
.../scripts/seed.ts |
Simplified counterparty ID generation and removed commented-out code related to creating businesses with end users. |
.../src/alert/alert.service.ts |
Modified alertDefinition structure to include a nested equals property for monitoringType . |
In code's vast field, we bunnies hop, With tweaks and changes, we never stop. Alerts now smarter, IDs split fine, Our scripts refined, in perfect line. With nested types and names so clear, The future's bright, no bugs to fear. 🐰✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
ALERT_DEFINITIONS
andMERCHANT_MONITORING_ALERT_DEFINITIONS
.Improvements
Code Cleanup
Also has data migration to approve