Closed Omri-Levy closed 1 month ago
Latest commit: dbf9de676f78c2173b6ca6d1b12e85f574c016f2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[!WARNING]
Rate limit exceeded
@Omri-Levy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 33 minutes and 12 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 9097d290694bc631b4d9b6f165bcee19fd0e0276 and dbf9de676f78c2173b6ca6d1b12e85f574c016f2.
The updates to the services/workflows-service
encompass dependency additions and version upgrades, enhancements to the alert generation script, and the introduction of a custom exception filter. Additionally, schema definitions and validations were integrated into various DTOs and service methods, ensuring stricter data handling and error management within the NestJS application.
File Path | Change Summary |
---|---|
services/workflows-service/package.json |
Added ballerine-nestjs-typebox dependency and updated @sinclair/typebox to 0.32.4 . |
.../scripts/alerts/generate-alerts.ts |
Made alertsDef parameter optional in generateAlertDefinitions function and handled undefined case. |
.../filters/AjvValidationException.filter.ts |
Introduced AjvValidationExceptionFilter for handling AjvValidationException errors. |
.../filters/filters.module.ts |
Added AjvValidationExceptionFilter to providers list. |
.../workflow/dtos/workflow-event-input.ts |
Added WorkflowEventInputSchema using @sinclair/typebox . |
.../workflow/dtos/workflow-where-unique-input.ts |
Defined WorkflowDefinitionWhereUniqueInputSchema using @sinclair/typebox . |
.../workflow/workflow.controller.internal.ts |
Enhanced DTO imports, added validation, and adjusted event method signatures. |
.../workflow/workflow.service.ts |
Updated imports and type declarations for event method to use WorkflowEventInputSchema . |
In the land of code, changes bright, Dependencies updated, schemas tight, Alerts now smarter, filters clear, Validations strong, no need to fear. A rabbit's joy, in code's embrace, With every change, a better place! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
AjvValidationException
errors with formatted responses.Improvements
Bug Fixes
alertsDef
parameter optional in alert generation script to handle undefined cases gracefully.Dependencies
ballerine-nestjs-typebox
dependency.@sinclair/typebox
to version0.32.4
.