Closed Omri-Levy closed 3 months ago
Latest commit: 96b6ce56b52a00086c12e49d7279570d4c6d0203
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[!WARNING]
Review failed
The pull request is closed.
These updates primarily focus on removing the recommendations
prop across various components and dataprocess flows in the business report domain, enhancing consistency and efficiency. Additionally, there are new configurations for useBusinessReportByIdQuery
and pluginWhiteList
, and several internal refactors aimed at streamlining the workflows and improving code maintainability.
File | Change Summary |
---|---|
apps/backoffice-v2/src/common/components/molecules/BusinessReportSummary/BusinessReportSummary.tsx |
Removed recommendations prop from BusinessReportSummary component. |
apps/backoffice-v2/src/common/components/molecules/ProcessTracker/constants.tsx |
Updated pluginsWhiteList to include 'merchant_monitoring' . |
apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts |
Removed recommendations field from reportAdapter data processing logic. |
apps/backoffice-v2/src/domains/business-reports/hooks/queries/useBusinessReportByIdQuery/useBusinessReportByIdQuery.tsx |
Introduced refetchInterval setting of 1_000_000 in the query configuration. |
apps/backoffice-v2/src/lib/blocks/variants/WebsiteMonitoringBlocks/hooks/useWebsiteMonitoringReportBlock/WebsiteMonitoringBusinessReportTab.tsx |
Removed recommendations prop from WebsiteMonitoringBusinessReportTab component props. |
apps/backoffice-v2/src/lib/blocks/variants/WebsiteMonitoringBlocks/hooks/useWebsiteMonitoringReportBlock/hooks/useWebsiteMonitoringBusinessReportTab/useWebsiteMonitoringBusinessReportTab.tsx |
Removed recommendations parameter from useWebsiteMonitoringBusinessReportTab function signature. |
services/workflows-service/prisma/data-migrations |
Updated subproject commit reference from 0f228510a350494324b08befb6fad83cd9b17baf to 51ca5af288f02ee4f548780e3540b409f517f993 . |
services/workflows-service/scripts/workflows/website-monitoring-workflow.ts |
Updated name property within websiteMonitoringDefinition to 'merchant_monitoring' . |
services/workflows-service/src/business-report/business-report.controller.internal.ts |
Added reportId field to data object in the createReport method of BusinessReportControllerInternal class. |
services/workflows-service/src/workflow/hook-callback-handler.service.ts |
Refactored to streamline functions, added setPluginStatusToSuccess , and optimized several methods for better flow. |
sequenceDiagram
participant Client
participant BusinessReportSummary
participant ProcessTracker
participant WebsiteMonitoringBusinessReportTab
participant BusinessReportControllerInternal
participant HookCallbackHandlerService
Note over Client: User initiates a report summary request.
Client ->> BusinessReportSummary: Request summary report without recommendations
BusinessReportSummary -->> ProcessTracker: Retrieve data including merchant monitoring
ProcessTracker -->> WebsiteMonitoringBusinessReportTab: Send data (no recommendations)
Note over BusinessReportSummary, ProcessTracker: Collaborate on report preparation
BusinessReportSummary ->> BusinessReportControllerInternal: Fetch report
BusinessReportControllerInternal -->> HookCallbackHandlerService: Process report with passthrough schemas
HookCallbackHandlerService -->> ProcessTracker: Update report status
BusinessReportControllerInternal ->> BusinessReportSummary: Deliver final report data
Note over Client: Client receives the updated business report
In code's vast plains we hop along, We pruned the props that don't belong. With data clean and plugins right, Our code now shines, oh what a sight. For every change, refined and neat, We celebrate - our work's complete! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
reportId
field in internal report data.Bug Fixes
pluginsWhiteList
to includemerchant_monitoring
.name
property inwebsiteMonitoringDefinition
with updated references.Refactor
recommendations
prop from multiple components and data processing logic.Enhancements
refetchInterval
setting to theuseBusinessReportByIdQuery
hook.