search

ballerine-io / ballerine

Open-source infrastructure and data orchestration platform for risk decisioning
https://www.ballerine.com
Other
2.05k stars 186 forks source link

feature/risk_rule_logic #2472

Closed Blokh closed 2 months ago

Blokh commented 3 months ago

Bal 2130 epic rule engine

Summary by CodeRabbit

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 5d1f3e7b64347f4f8f0bf0bce7d66a355d27eccf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes introduce new functionalities and dependencies to the workflows-service module, including integrations with Notion and AWS services, rule engine enhancements, and schema updates. Major additions include new services for handling Notion data, risk rules, and a rule engine module. Several tests and existing services were updated to accommodate these enhancements.

Changes

File/Path Change Summary
services/workflows-service/package.json Removed ballerine-nestjs-typebox. Added dependencies for Notion, AWS SDK, Sentry, and more.
services/workflows-service/prisma/data-migrations Updated subproject commit references.
services/workflows-service/src/app.module.ts Imported and included RuleEngineModule.
services/workflows-service/src/env.ts Added NOTION_API_KEY to serverEnvSchema.
services/workflows-service/src/notion.service.ts Added NotionService for interacting with Notion API.
services/workflows-service/src/risk-rule.service.ts Added RiskRuleService for managing and validating risk rules.
services/workflows-service/src/rule-engine/core/... Introduced core rule engine functionalities, error handling, operators, schemas, and types.
services/workflows-service/src/rule-engine.module.ts Created RuleEngineModule with RuleEngineService and RuleStoreService providers.
services/workflows-service/src/rule-engine.service.ts Added RuleEngineService with a method to execute rules on form data.
services/workflows-service/src/workflow/workflow.service.ts Updated WorkflowService to include RuleEngineService and RiskRuleService.
apps/kyb-app/src/components/organisms/.../PageResolver.tsx Moved import statement for pageResolverContext.
apps/kyb-app/src/components/organisms/.../array.insertion-strategy.ts Adjusted handling of pickFrom values in ArrayInsertionStrategy class.
apps/kyb-app/src/components/organisms/.../types.ts Modified InsertionSchema type to allow strings or arrays of strings.
services/workflows-service/prisma/migrations/.../migration.sql Added migration script to alter "UiDefinition" table by adding a JSONB locales column.
services/workflows-service/prisma/schema.prisma Adjusted relationships and data types in various models.
services/workflows-service/src/collection-flow/... Added RuleEngineModule import and updated method signatures and parameters.
services/workflows-service/src/end-user/dtos/end-user-update.ts Updated EndUserUpdateDto class to include new properties with validation decorators.
services/workflows-service/src/providers/translation/... Updated TranslationService handling and resource management.
services/workflows-service/src/end-user/end-user.controller.external.intg.test.ts Added imports for RiskRuleService, RuleEngineService, and NotionService.
services/workflows-service/src/workflow/... Added imports for RiskRuleService, RuleEngineService, and NotionService in various test files.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant NotionService
    participant RiskRuleService
    participant RuleEngineService

    Client->>NotionService: Request database records
    NotionService->>Client: Return records
    Client->>RiskRuleService: Fetch and validate risk rules
    RiskRuleService->>Client: Return validated rules
    Client->>RuleEngineService: Execute rules on form data
    RuleEngineService->>Client: Return rule execution results

Poem

In the codebase deep and wide,
New Notion connections now reside.
AWS tools lend a hand,
To store and fetch on command.
Rules and risks we now can see,
Enhanced with logic, joyous and free.
Celebrate, dear coders, with glee! 🎉🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ballerine-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:24am