search

ballerine-io / ballerine

Open-source infrastructure and data orchestration platform for risk decisioning
https://www.ballerine.com
Other
2.04k stars 183 forks source link

feat: implemented extensions update & definition update & added endpoints #2542

Closed chesterkmr closed 1 month ago

chesterkmr commented 1 month ago

Summary by CodeRabbit

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: e85ac9578c7418e8602b3462e1e3fcc326347b3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates to the workflows-dashboard application introduce enhanced notification handling and improved editing capabilities for workflow definitions. Key features include the integration of the Sonner library for toast notifications, the addition of new APIs for updating workflow definitions and extensions, and refined hooks for managing state within components. Overall, these changes aim to provide a more responsive and user-friendly experience.

Changes

File Path Change Summary
apps/workflows-dashboard/package.json Added "sonner": "^1.4.3" dependency for enhanced notification handling.
apps/workflows-dashboard/src/App.tsx Introduced Toaster component for toast notifications within the application.
apps/workflows-dashboard/src/components/organisms/JsonEditor/JsonEditor.tsx Updated useEffect hooks to improve editor behavior based on readOnly state.
apps/workflows-dashboard/src/domains/workflow-definitions/workflow-definitions/workflow-definitions.api.ts Added updateWorkflowDefinitionById and updateWorkflowDefinitionExtensionsById functions for API updates.
apps/workflows-dashboard/src/domains/workflow-definitions/workflow-definitions/workflow-definitions.types.ts Enhanced IWorkflowDefinition interface and added DTOs for update operations.
apps/workflows-dashboard/src/pages/WorkflowDefinition/WorkflowDefinition.tsx Integrated useWorkflowDefinitionExtensionsEdit hook for managing extensions, simplified data queries.
apps/workflows-dashboard/src/pages/WorkflowDefinition/components/EditorCard/EditorCard.tsx Modified button logic for saving changes, introducing "Upgrade" and "Update" buttons.
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionEdit/useWorkflowDefinitionEdit.ts Refactored save logic, renamed handlers, and improved update process using hooks.
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionExtensionsEdit/useWorkflowDefinitionExtensionsEdit.ts Introduced hook for managing workflow definition extensions.
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionExtensionsUpdateMutation/... Re-exporting modules for streamlined access to extension update functionalities.
services/workflows-service/src/workflow-defintion/dtos/update-workflow-definition-dto.ts Introduced DTO for updating workflow definitions, enhancing validation.
services/workflows-service/src/workflow-defintion/workflow-definition.controller.ts Added new methods for updating workflow definitions and extensions in the controller.
services/workflows-service/src/workflow-defintion/workflow-definition.repository.ts Modified updateMany method to include a noValidate option for flexible updates.
services/workflows-service/src/workflow-defintion/workflow-definition.service.ts Added methods for updating workflow definitions, improving service interactions.
services/workflows-service/src/workflow/workflow.controller.external.ts Enhanced getWorkflowDefinitionById to include UI definitions in response.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant API
    participant Service
    participant DB

    User->>App: Requests to update workflow definition
    App->>Service: Calls updateWorkflowDefinitionById
    Service->>DB: Updates workflow definition
    DB-->>Service: Acknowledgement of update
    Service-->>App: Updated workflow definition
    App-->>User: Confirmation of update

Poem

🐰 In the meadow where workflows bloom,
A toast to changes brightening the room.
With Sonner's cheer and edits anew,
Our definitions dance, fresh as the dew.
Hops of joy, let's celebrate,
In code we trust, we innovate! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.