search

ballerine-io / ballerine

Open-source infrastructure and data orchestration platform for risk decisioning
https://www.ballerine.com
Other
2.04k stars 183 forks source link

Illiar/feat/wf dashboard state editing #2566

Closed chesterkmr closed 1 month ago

chesterkmr commented 1 month ago

Summary by CodeRabbit

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 6245ba25979ee1593309b882aa3b277c2bedbe8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent updates to the workflows dashboard significantly enhance functionality and streamline the codebase. Key changes include the introduction of new components for managing workflow states, improved data structures, and refined API interactions. Redundant console logs were removed for cleaner code, and the organization of exports has been optimized. These adjustments collectively improve user experience and maintainability within the application.

Changes

Files Change Summary
apps/workflows-dashboard/src/common/hooks/useWorkflowDefinitionQuery/useWorkflowDefinitionQuery.ts Removed console log for improved cleanliness, no functional changes.
apps/workflows-dashboard/src/components/atoms/Select/Select.tsx Rearranged export order for better organization, no functionality changes.
apps/workflows-dashboard/src/components/molecules/WorkflowsTable/columns.tsx Updated state column to use StateUpdaterColumn, enhancing interactivity.
apps/workflows-dashboard/src/components/molecules/WorkflowsTable/components/StateUpdaterColumn/*.ts Introduced StateUpdaterColumn for dynamic state management in workflows.
apps/workflows-dashboard/src/domains/workflows/api/workflow/*.ts Added updateWorkflowState and sendWorkflowEvent functions to improve workflow API capabilities.
apps/workflows-dashboard/src/domains/workflows/api/workflow/workflow.types.ts Expanded type definitions for workflows, adding new interfaces for better data handling.
apps/workflows-dashboard/src/pages/Filters/Filters.tsx Removed console log, core functionality unchanged.
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionExtensionsUpdateMutation/useWorkflowDefinitionExtensionsUpdateMutation.ts Adjusted import path for IWorkflowDefinition, no functional changes.
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionUpdateMutation/useWorkflowDefinitionUpdateMutation.ts Changed import for IWorkflowDefinition, maintaining existing logic.
apps/workflows-dashboard/src/pages/Workflows/components/molecules/ActivePerWorkflowChart/ActivePerWorkflowChart.tsx Removed console log, functionality intact.
apps/workflows-dashboard/src/pages/Workflows/helpers/deserialize-query-params.ts Removed orderBy and orderDirection from output, affecting how workflows are queried.
apps/workflows-dashboard/src/pages/Workflows/hooks/useSendWorkflowEventMutation/*.ts Introduced hook for sending workflow events and managing mutations.
apps/workflows-dashboard/src/pages/Workflows/hooks/useUpdateWorkflowsStateMutation/*.ts Added hook for updating workflow states with optimistic UI updates.
services/workflows-service/prisma/data-migrations Updated subproject commit reference.
services/workflows-service/src/workflow/workflow-runtime-list-item.model.ts Added workflowDefinition property with validation in data model.
services/workflows-service/src/workflow/workflow.controller.external.ts Removed authorization guard and updated return type for an event handler.
services/workflows-service/src/workflow/workflow.service.ts Enhanced import statements for additional services and capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant WorkflowAPI
    participant WorkflowService

    User->>UI: Trigger Workflow Event
    UI->>WorkflowAPI: Send workflow event data
    WorkflowAPI->>WorkflowService: Process event
    WorkflowService-->>WorkflowAPI: Return updated status
    WorkflowAPI-->>UI: Update UI with new status
    UI-->>User: Show success notification

🐇 In the meadow, changes bloom,
With fewer logs, there's more room.
New components leap and play,
Enhancing workflows every day.
Hooray for structure, neat and bright,
In code we hop, with pure delight! 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.