Closed chesterkmr closed 1 month ago
Latest commit: 6245ba25979ee1593309b882aa3b277c2bedbe8a
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[!CAUTION]
Review failed
The pull request is closed.
The recent updates to the workflows dashboard significantly enhance functionality and streamline the codebase. Key changes include the introduction of new components for managing workflow states, improved data structures, and refined API interactions. Redundant console logs were removed for cleaner code, and the organization of exports has been optimized. These adjustments collectively improve user experience and maintainability within the application.
Files | Change Summary |
---|---|
apps/workflows-dashboard/src/common/hooks/useWorkflowDefinitionQuery/useWorkflowDefinitionQuery.ts |
Removed console log for improved cleanliness, no functional changes. |
apps/workflows-dashboard/src/components/atoms/Select/Select.tsx |
Rearranged export order for better organization, no functionality changes. |
apps/workflows-dashboard/src/components/molecules/WorkflowsTable/columns.tsx |
Updated state column to use StateUpdaterColumn , enhancing interactivity. |
apps/workflows-dashboard/src/components/molecules/WorkflowsTable/components/StateUpdaterColumn/*.ts |
Introduced StateUpdaterColumn for dynamic state management in workflows. |
apps/workflows-dashboard/src/domains/workflows/api/workflow/*.ts |
Added updateWorkflowState and sendWorkflowEvent functions to improve workflow API capabilities. |
apps/workflows-dashboard/src/domains/workflows/api/workflow/workflow.types.ts |
Expanded type definitions for workflows, adding new interfaces for better data handling. |
apps/workflows-dashboard/src/pages/Filters/Filters.tsx |
Removed console log, core functionality unchanged. |
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionExtensionsUpdateMutation/useWorkflowDefinitionExtensionsUpdateMutation.ts |
Adjusted import path for IWorkflowDefinition , no functional changes. |
apps/workflows-dashboard/src/pages/WorkflowDefinition/hooks/useWorkflowDefinitionUpdateMutation/useWorkflowDefinitionUpdateMutation.ts |
Changed import for IWorkflowDefinition , maintaining existing logic. |
apps/workflows-dashboard/src/pages/Workflows/components/molecules/ActivePerWorkflowChart/ActivePerWorkflowChart.tsx |
Removed console log, functionality intact. |
apps/workflows-dashboard/src/pages/Workflows/helpers/deserialize-query-params.ts |
Removed orderBy and orderDirection from output, affecting how workflows are queried. |
apps/workflows-dashboard/src/pages/Workflows/hooks/useSendWorkflowEventMutation/*.ts |
Introduced hook for sending workflow events and managing mutations. |
apps/workflows-dashboard/src/pages/Workflows/hooks/useUpdateWorkflowsStateMutation/*.ts |
Added hook for updating workflow states with optimistic UI updates. |
services/workflows-service/prisma/data-migrations |
Updated subproject commit reference. |
services/workflows-service/src/workflow/workflow-runtime-list-item.model.ts |
Added workflowDefinition property with validation in data model. |
services/workflows-service/src/workflow/workflow.controller.external.ts |
Removed authorization guard and updated return type for an event handler. |
services/workflows-service/src/workflow/workflow.service.ts |
Enhanced import statements for additional services and capabilities. |
sequenceDiagram
participant User
participant UI
participant WorkflowAPI
participant WorkflowService
User->>UI: Trigger Workflow Event
UI->>WorkflowAPI: Send workflow event data
WorkflowAPI->>WorkflowService: Process event
WorkflowService-->>WorkflowAPI: Return updated status
WorkflowAPI-->>UI: Update UI with new status
UI-->>User: Show success notification
🐇 In the meadow, changes bloom,
With fewer logs, there's more room.
New components leap and play,
Enhancing workflows every day.
Hooray for structure, neat and bright,
In code we hop, with pure delight! 🥕
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
StateUpdaterColumn
component that allows users to interactively update workflow states and send events.Bug Fixes
Refactor
Select
component for better clarity.deserializeQueryParams
function output structure to remove deprecated properties.Documentation
useSendWorkflowEventMutation
anduseUpdateWorkflowsStateMutation
hooks.Chores