search

ballerine-io / ballerine

Open-source infrastructure and data orchestration platform for risk decisioning
https://www.ballerine.com
Other
2.04k stars 183 forks source link

Ability to store customer secrets and consume them in workflows #2569

Closed MatanYadaev closed 1 month ago

MatanYadaev commented 1 month ago

Summary by CodeRabbit

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: bf619ee08fead9d076f9221b5c5214cba623c1e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@MatanYadaev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 34 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between cdfe342b84ed6c9edf8c5c8b6c392bc66f71f656 and bf619ee08fead9d076f9221b5c5214cba623c1e2.

Walkthrough

This update enhances the workflow-core and workflows-service modules by introducing robust secret management capabilities. New classes and interfaces facilitate the secure handling of secrets, while existing workflows have been modified for seamless integration. Additionally, several dependency updates across various packages improve performance and stability, ensuring the application operates smoothly with the latest features and fixes.

Changes

Files Change Summary
packages/workflow-core/... Added secretsManager parameter to createWorkflow function and enhanced plugins for secret management.
services/workflows-service/... Integrated new secret management classes and updated WorkflowService to utilize SecretsManagerFactory.
services/workflows-service/.env.example Added environment variables for AWS Secrets Manager configuration.
services/workflows-service/src/... Improved modules and removed WorkflowService in favor of a more integrated WorkflowModule.
apps/backoffice-v2/..., apps/kyb-app/..., examples/headless-example/..., packages/workflow-core/..., sdks/workflow-browser-sdk/..., sdks/workflow-node-sdk/..., services/workflows-service/... Updated version numbers and dependencies (e.g., @ballerine/workflow-browser-sdk to 0.6.27).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WorkflowService
    participant SecretsManagerFactory
    participant SecretsManager

    User->>WorkflowService: Initiate Workflow
    WorkflowService->>SecretsManagerFactory: Create SecretsManager instance
    SecretsManagerFactory->>SecretsManager: Return SecretsManager instance
    WorkflowService->>SecretsManager: Access Secrets
    SecretsManager-->>WorkflowService: Provide Secrets
    WorkflowService-->>User: Complete Workflow

🐰 In the meadow, secrets sway,
🐇 With new powers, they come to play.
🌼 Whispers of AWS in the breeze,
🌈 Hidden treasures, a joyful tease.
🥕 Let’s hop along, with cheer and delight,
✨ For workflows and secrets, the future is bright!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.