Closed MatanYadaev closed 1 month ago
Latest commit: bf619ee08fead9d076f9221b5c5214cba623c1e2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
[!WARNING]
Rate limit exceeded
@MatanYadaev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 34 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between cdfe342b84ed6c9edf8c5c8b6c392bc66f71f656 and bf619ee08fead9d076f9221b5c5214cba623c1e2.
This update enhances the workflow-core
and workflows-service
modules by introducing robust secret management capabilities. New classes and interfaces facilitate the secure handling of secrets, while existing workflows have been modified for seamless integration. Additionally, several dependency updates across various packages improve performance and stability, ensuring the application operates smoothly with the latest features and fixes.
Files | Change Summary |
---|---|
packages/workflow-core/... |
Added secretsManager parameter to createWorkflow function and enhanced plugins for secret management. |
services/workflows-service/... |
Integrated new secret management classes and updated WorkflowService to utilize SecretsManagerFactory . |
services/workflows-service/.env.example |
Added environment variables for AWS Secrets Manager configuration. |
services/workflows-service/src/... |
Improved modules and removed WorkflowService in favor of a more integrated WorkflowModule . |
apps/backoffice-v2/... , apps/kyb-app/... , examples/headless-example/... , packages/workflow-core/... , sdks/workflow-browser-sdk/... , sdks/workflow-node-sdk/... , services/workflows-service/... |
Updated version numbers and dependencies (e.g., @ballerine/workflow-browser-sdk to 0.6.27 ). |
sequenceDiagram
participant User
participant WorkflowService
participant SecretsManagerFactory
participant SecretsManager
User->>WorkflowService: Initiate Workflow
WorkflowService->>SecretsManagerFactory: Create SecretsManager instance
SecretsManagerFactory->>SecretsManager: Return SecretsManager instance
WorkflowService->>SecretsManager: Access Secrets
SecretsManager-->>WorkflowService: Provide Secrets
WorkflowService-->>User: Complete Workflow
π° In the meadow, secrets sway,
π With new powers, they come to play.
πΌ Whispers of AWS in the breeze,
π Hidden treasures, a joyful tease.
π₯ Letβs hop along, with cheer and delight,
β¨ For workflows and secrets, the future is bright!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
AwsSecretsManager
andSecretsManagerFactory
.Improvements
Configuration
Bug Fixes