search

ballsteve / xrust

XPath, XQuery, and XSLT for Rust
Apache License 2.0
89 stars 9 forks source link

Starting work on CDATA Support #17

Closed Devasta closed 2 years ago

Devasta commented 2 years ago

Hi Steve,

I've started some work on getting CDATA support built into the parser, let me know what you think. I still need to do some work on catching invalid characters and the like so will be make more changes regardless.

Regards

Dan

ballsteve commented 2 years ago

I have to check whether CDATA sections can be nested.

ballsteve commented 2 years ago

CDATA sections cannot be nested, so don't worry about trying to support that.

Devasta commented 2 years ago

Thanks

By the way, I can see the commit seems very large because the indentation on a bunch fo stuff has changed, think that was my IDE. Sorry about that, won't happen again!

ballsteve commented 2 years ago

I’ve made a couple of changes to variable names since rustc doesn’t like capitals. See my latest push.

Cheers, Steve

On 14 Feb 2022, at 12:39 am, Daniel Murphy @.***> wrote:

Thanks

By the way, I can see the commit seems very large because the indentation on a bunch fo stuff has changed, think that was my IDE. Sorry about that, won't happen again!

— Reply to this email directly, view it on GitHub https://github.com/ballsteve/xrust/pull/17#issuecomment-1038124457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUCP5QNSITCBFC6IVJO6I5LU26X7RANCNFSM5OGCIQOA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you modified the open/close state.