search

ballsteve / xrust

XPath, XQuery, and XSLT for Rust
Apache License 2.0
89 stars 9 forks source link

Partialeq #84

Closed ballsteve closed 4 months ago

ballsteve commented 4 months ago

Implements the PartialEq trait for trees.

What is actually happening is that PartialEq is a supertrait of item::Node. The Node trait then defines an 'eq' method and provides a default implementation that utilises the generic methods to navigate both trees.

Smite can't use the default implementation, so it gets its own 'eq' method for the smite::Node type.

Devasta commented 4 months ago

This is merging to main? Should be dev instead right?

The change looks good, can be merged.

ballsteve commented 4 months ago

Hi Daniel,

Oops! Yes, you’re right.

Cheers, Steve

On 12 Jul 2024, at 8:31 AM, Daniel Murphy @.***> wrote:

This is merging to main? Should be dev instead right?

The change looks good, can be merged.

— Reply to this email directly, view it on GitHub https://github.com/ballsteve/xrust/pull/84#issuecomment-2224062449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUCP5QPO3NNFXNCJVE7VGJ3ZL4BUBAVCNFSM6AAAAABKWXTYL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUGA3DENBUHE. You are receiving this because you authored the thread.

Devasta commented 4 months ago

Right, I cannot change the pull request target so I am going to close this and open a different request, but it all looks good.