balmbees / dynamo-types

Typescript AWS DynamoDB ORM
231 stars 18 forks source link

Feature/condition #47

Closed mooyoul closed 4 years ago

mooyoul commented 4 years ago

Is it a breaking change?: Maybe

Why did you make these changes?

Closes #30

See https://github.com/balmbees/dynamo-types/issues/30#issuecomment-554690291

What's changed in these changes?

What do you especially want to get reviewed?

N/A

Is there any other comments that every teammate should know?

Now PrimaryKey#update guarantees type safety:

스크린샷 2019-11-17 오후 3 58 18

Condition also respects original type:

스크린샷 2019-11-17 오후 3 59 43

Submission Type

All Submissions

mooyoul commented 4 years ago

Note: Published this PR as a beta release (v2.9.0-beta.0) to canary channel (npm i dynamo-types@canary)

mooyoul commented 4 years ago

Just published v2.9.1-beta.1 which fixes invalid type inferences in derived class methods (e.g. Table#save with conditions, Table#delete with conditions)