balmbees / dynamo-types

Typescript AWS DynamoDB ORM
231 stars 18 forks source link

Remove `Decorator` namespace #55

Closed MickL closed 4 years ago

MickL commented 4 years ago

Doesnt it make sense to remove the Decorator namespace for all decorators?

E.g.@Decorator.Table() to @Table().

As a reference I would like to point to TypeORM or Angular which dont prefix their decorators, too.

breath103 commented 4 years ago
  @Decorator.Table({ name: "prod-Card" })
  class Card extends Table {
    @Decorator.Attribute()
    public id: number;

    @Decorator.Attribute()
    public title: string;

    @Decorator.Attribute({ timeToLive: true })
    public expiresAt: number;

    @Decorator.FullPrimaryKey('id', 'title')
    static readonly primaryKey: Query.FullPrimaryKey<Card, number, string>;

    @Decorator.Writer()
    static readonly writer: Query.Writer<Card>;
  }

we have to. otherwise we can't distinguish "class Table" from "decorator Table"

we could do "TableDecorator" instead of @Decorator.Table, which as you can see not much difference i'd say