jgeab
commented
4 years ago Dear Ida (and Søren), Thank you for your great work! I have reviewed the code and I have some comments/suggestions:
- I think you should move all the infeasibility variables and stuff in the equations to the vqdebug add-on. This will not only make the code easier but much more efficient.
- Please add to the equation QHYDROGEN_STOVOL the following filter at the beginning: AND IS3(S) This change will make it almost ready for the rolling seasons mode (the new more advanced BB3 mode)
- Please add to the equations where GKFX and VGKNACCUMNET is used the following deccommissioning line so it can also work with the decommisioning add-on. Change IGBPR with the convenient set:
$ifi %DECOM%==yes -VDECOM_EXO_ACCUM(IY411,IA,IGBPR)$IGDECOMEXOPOT(IY411,IA,IGBPR) - The definition of AGKN and other already existing parameters should be done after, for example, AGKN is defined. With this we will not have problems related to overwriting or missing stuff. However, I can see that this branch of the model does not have the code to do so, so I would really appreciate if a not is taken on this issue and this is fixed in the near future.
- Equation QGKE_UP_ADD is missing IGKRATE factor, I think.
- What is this equation for: QHYDROGEN_GCH4KT? Does it make sense?
- What is the variable VHYDROGEN_STOVOL_S for? Can it be removed?
- In the future, I will modify the export file of this add-on (hydrogen storage levels) so it works with the import-export add-on (useful for example for the seasonal rolling horizon mode)
I have updated the hydrogen add-on to include the changes suggested by master's thesis student Søren. Note that I have let the Combtech and Hydrogen add-on options in balopt in order for you to test it. This should maybe be reverted for the final merge. I have also (soon) a pending data pull request, which it should be tested with.