baloise / design-system

The Baloise Design System consists of reusable components and a clearly defined visual style, that can be assembled together to build any number of applications.
https://design.baloise.dev
Apache License 2.0
100 stars 27 forks source link

:wheelchair: a11y(tab-component): Keyboard interaction of tabs #1425

Open carolabes opened 4 months ago

carolabes commented 4 months ago

Description of this issue

tabs

How to fix it

Additional Information

Level A https://www.w3.org/WAI/WCAG21/Understanding/keyboard.html

Keyboard interaction: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#keyboard_interaction

Code of Conduct

hirsch88 commented 4 months ago

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#keyboard_interactions

hirsch88 commented 4 months ago

@carolabes We need to discuss this in our weekly.

There are 3 cases for the tabs

  1. Tabs with only links should work with tab and enter
  2. Tabs without any link should work with arrow keys
  3. But we also have a mixture like in the main nav bar, would do we there?

Moreover, we get the feeling that we are confusing the end user with multiple solutions

carolabes commented 3 months ago

Hi @hirsch88, the technical implementation is important for people who cannot see the design. Based on the implementation, they can identify the element and know how to access it. By definition, the tab changes parts of the page (see tab role definition). Technically we have only one use case here.

This means:

  1. Tabs with links only like our inpage navigation should be implemented as nav with link list.
  2. Tabs that change parts of the content such as the tab component or product slider should be implemented as tabs and thus be operable.
  3. In main nav bar no tabs are necessary, because it is a navigation. Here buttons and links are enough.

I understand your point that it can be confusing for the users, but still the technical implementation should be correct for the users who don't see the design.

If there are any questions, please do not hesitate to contact me.

hirsch88 commented 3 months ago

/cib

github-actions[bot] commented 3 months ago

Branch fix/issue-1425 created!

carolabes commented 1 week ago

Checked on Baloise.ch: Accessing with right&left arrow key not possible

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#keyboard_interactions