search

baloise / digital-signature

a digital signature confluence macro
https://marketplace.atlassian.com/1217404
Apache License 2.0
8 stars 8 forks source link

Unmodifiable contract #1

Open culmat opened 7 years ago

culmat commented 7 years ago

After beeing signed a contract should not be modified. Currently this is possible. The signatures go away and come back if I change back to a signed text, but there is no warning, so handling is error prone.

(Reported by JMB)

culmat commented 7 years ago

I see no way to get hold of a unique macro instance ID. So the ID is calculated as hash over title and body. See https://jira.atlassian.com/browse/CONFSERVER-52819

This has also negative impact on storage, as macros are stored in every version, even when not signed and never deleted.

amragl commented 6 years ago

The add on is a great alternative to Page Approval, however the fact that you can't modify contract is an issue. When changing txt in the box, my signature and the checkbox ticked are removed, however I don't get the option to sign it again.

Would be nice if it could be fixed.

Thanks.

culmat commented 6 years ago

Hello, thanks for your feedback. Which version of the plugin are you using? Did you check the signers / signerGroups / inheritSigners / maxSignatures options? I can not reproduce the error. When I change the content I can sign again. Best regards. Mattthias

amragl commented 6 years ago

HI, I've changed the maxSignature option and it seems to work now. There are two options that I can see and wonder if they will be added;

  1. A button to remove individual approval.
  2. History of who approved and removed approval. Thanks.
culmat commented 6 years ago
  1. This is currently not planned. We try to model a real signature. Once you sign a contract you should not be able to erase that signature. What would be the exact use case here?
  2. The history of approval (who signed and when) is an integral part of the macro. It is rendered in the macro as well as in the export. Where else would you like this information to be displayed?
amragl commented 6 years ago

Thank you.

culmat commented 3 years ago

there is news on this topic, see https://jira.atlassian.com/browse/CONFSERVER-52819?focusedCommentId=2651903&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2651903

Changing the storage logic would certainly break backwards compatibility.

Tiliavir commented 2 years ago

@culmat how about a fallback approach to maintain backward compatibility? i.e. try to read with macro-id - if nothing is found, fallback to null/current implementation?