baloise / digital-signature

a digital signature confluence macro
https://marketplace.atlassian.com/1217404
Apache License 2.0
8 stars 8 forks source link

Position of the signature button should be flexible #26

Closed pbaumi closed 3 years ago

pbaumi commented 6 years ago

Hey, very nice Add-On! As we alwayys have longer lists of signers (80+) AND have to integrate the macro in a page that people have to be able to read, it would be very nice to be able to specify the position of the signature-button and show/ hide the list of signers in the macro view (the list view in the background provides a complete overview). We'll try to figure something ourselves, any pointers would be highly appreciated. Thanks again for your great work!

culmat commented 6 years ago

Thanks for the compliment :-) My first thoughts

  1. count signatures
  2. if more than THRESHOLD display only last SOME and and put the rest into a expander

Should be quite straight forward to implement in DigitalSignatureMacro.java and macro.vm

I guess less options are better. The macro parameter list grows fast and it will be increasingly difficult to maintain backwards compatablility.

Tiliavir commented 4 years ago

@culmat I've just pushed a first approach for this issue, implementing a threshold and some sort of expander logic.

image

Tiliavir commented 3 years ago

Hi @pbaumi

This was fixed in 7.0.2 and is available on the atlassian marketplace.

Best regards Markus