baloise / digital-signature

a digital signature confluence macro
https://marketplace.atlassian.com/1217404
Apache License 2.0
8 stars 8 forks source link

Contract titel #46

Closed n102142 closed 4 years ago

n102142 commented 4 years ago

Hello everyone,

is it possible to configure that the contract titel is always the document titel, maybe with a variable?

Thank you!

culmat commented 4 years ago

Hello n102142,

yes this is totally possible. We could use a magic word i.e $pageTitle to indicate that the title should be inherited from the page.

The draw back I see is: it is encouraging people to have the contract content in the page and use the signature macro only with minimal text, though only the content of the macro is hashed into the signature. See Signature Macro Usage

Please be aware the containing page can still be modified so the signature only applies to the content inside macro title and body. You don't sign the page but the content of the contract.

Wouldn't this be misleading? Best regards. Matthias

Jokabu2 commented 4 years ago

Hello Matthias,

thank you!

Yes I see you point. We use this marco in a different context. Somebody creates a new page by using a template. At the top is the content and documentation and in the bottom of the page there is the sign macro. We use the sign to approve the Confluecne page.

Best regards. Tomas

culmat commented 4 years ago

Hello Tomas,

IMHO this is a similar but different use case - it is a page approval, not a contract. After approval can you still edit the page? What shall than happen to the signature? I guess the signature should be linked to the content of the page ( storage format)? ( Knowing that with page includes and other macros the content can change on every refresh ) We could have a body-less macro ( I don't see the need for title and body?)

I guess we could also go light on the other parameters ( like protected child page - do you need that? )

What do you think? Best regards. Matthias

Jokabu2 commented 4 years ago

Thank you for the input. The different points you asked are very helpful but we only want to use the very basic functionalities.

Thank you!

Tiliavir commented 4 years ago

Hi @Jokabu2

One of the following macros, designed solely for the use case you describe, might better fit your needs:

However, this is an interesting scenario we might want to pick up for a new macro in the future.

Best regards Markus