search

baloise / rocket-chat-rest-client

Java REST client API for Rocket.Chat
MIT License
50 stars 38 forks source link

Find deputy codeowner for "baloise/rocket-chat-rest-client" #34

Open MarkusTiede opened 5 years ago

MarkusTiede commented 5 years ago

https://github.com/baloise/rocket-chat-rest-client/blob/master/docs/CODEOWNERS

MarkusTiede commented 5 years ago

37 partially addressed this.

MarkusTiede commented 5 years ago

@culmat : Do you think this is sufficient? IMHO: Yes.

col-panic commented 5 years ago

Seems like https://github.community/t5/How-to-use-Git-and-GitHub/Do-not-require-owner-approval-if-the-pull-request-is-from-an/td-p/1331/page/4 blocks me from approving my own PRs ....

MarkusTiede commented 5 years ago

@col-panic - could you re-check? I've disabled the review requirement for master branch protection for now:

Bildschirmfoto 2019-10-10 um 14 44 56

col-panic commented 5 years ago

works now! thx!