search

balraj-johal / LearnPunjabi

An interactive learning platform to teach Punjabi, the 10th most spoken language in the world!
https://www.learnpunjabi.academy
0 stars 0 forks source link

fix rivers end mismatches on ranges of vh #105

Open balraj-johal opened 2 years ago

balraj-johal commented 2 years ago

issue remains on smaller heights as the first svg does not fill height correctly

balraj-johal commented 2 years ago

currently considering, instead of adding loads of single rivers middle svg's, if I create one 10,000px high rivers top middle and end element, it'll remove in-section alignment errors, and possibly make animation an option? what it likely still won't do is stop between section alignment errors.

that will probably have to be fixed by making the svg widths a function of viewport height, as it's on height changes that the issues occur.