balthazar / ng-markdown

:memo: [DEPRECATED] Markdown directive for AngularJS
http://apercu.github.io/ng-markdown/
MIT License
12 stars 1 forks source link

provide unminified versions in ./dist for bower package #9

Closed ralyodio closed 10 years ago

ralyodio commented 10 years ago

ideally, it would not be in a subdirectory of the bower package, it should be in the root. both minified and unminified versions.

balthazar commented 10 years ago

I want to keep the repo as clean as possible, that's why I organised everything in folders.

For the unminified versions, did you talk about the compiled .css and the concaneted .js file that contains all the Markdown files and the directive ? I can eventually create a task to generate it, but it will be in the dist folder.

ralyodio commented 10 years ago

The yeoman build generator expects libs to be in root, not a subdir.

balthazar commented 10 years ago

Hum can you please give the source for this ? Will go for it if it's the general convention

ralyodio commented 10 years ago

I don't recall where I read this, I think it was on the angulare-fullstack generator issues somewhere. All I can tell you is if the source files aren't in the root dir, then it doesn't get picked up by that generator.

balthazar commented 10 years ago

Have you already experienced this issue ? Using the angular-fullstack generator 1.4.3, never had this problem.

It takes the content of the package.json to inject the dependencies in the index.html, I referenced the good paths in it so all should work well.

Anyway I'll test it with the new 2.0 release to see if it still works

ralyodio commented 10 years ago

Yes. I have it on all bower scripts where the file is not in root. You have to statically include them and they don't become part of vendor.js

-- Anthony

On Jul 3, 2014, at 5:29 AM, Apercu notifications@github.com wrote:

Have you already experienced this issue ? Using the angular-fullstack generator 1.4.3, never had this problem.

It takes the content of the ˋpackage.jsonˋ to inject the dependencies in the ˋindex.htmlˋ, I referenced the good paths in it so all should work well.

Anyway I'll test it with the new 2.0 release to see if it still works

— Reply to this email directly or view it on GitHub.

balthazar commented 10 years ago

Interesting, could you please link me the concerned scripts and / or the project generated with angular-fullstack you had the issue ?

ralyodio commented 10 years ago

My project isn't on github. But here's the index.html from that generator project I'm using:

<!-- build:js(app) scripts/vendor.js -->
<!-- bower:js -->
<script src="bower_components/jquery/dist/jquery.js"></script>
<script src="bower_components/angular/angular.js"></script>
<script src="bower_components/angular-resource/angular-resource.js"></script>
<script src="bower_components/angular-cookies/angular-cookies.js"></script>
<script src="bower_components/angular-route/angular-route.js"></script>
<script src="bower_components/angular-sanitize/angular-sanitize.js"></script>
<script src="bower_components/angular-markdown-directive/markdown.js"></script>
<script src="bower_components/angular-animate/angular-animate.js"></script>
<script src="bower_components/moment/moment.js"></script>
<script src="bower_components/angular-moment/angular-moment.js"></script>
<script src="bower_components/i18next/i18next.js"></script>
<script src="bower_components/i18ng/i18ng.js"></script>
<script src="bower_components/lodash/dist/lodash.compat.js"></script>
<script src="bower_components/angular-elastic/elastic.js"></script>
<!-- endbower -->
<!-- endbuild -->

<!-- static js includes -->
<script src="bower_components/showdown/compressed/showdown.js"></script>
<script src="bower_components/ng-markdown/dist/ng-markdown.min.js"></script>
<!-- end static includes -->
balthazar commented 10 years ago

Very strange behavior, have you also the problem with jquery and lodash or not ?

I just generated a project using the angular-fullstack generator 2.0.2 and everything work just as expected. Did you run the bower install with --save option ?

ralyodio commented 10 years ago

Yes. I did. There seems to be a problem with certain scripts. Yours was one of them. Showdown.js was the other problematic one. The guys over on that generator said its because its not in the root directory.