search

baltimorecounty / baltimorecountymd.gov-assets

Baltimore County Government Website Assets
3 stars 1 forks source link

Smartbanner throwing errors #238

Closed martypowell closed 5 years ago

martypowell commented 6 years ago

A console errors is thrown on this page. https://www.baltimorecountymd.gov/iwant/apply.html

We do not want this error to show.

Requirements

martypowell commented 6 years ago

@danfox01 where are we using smartbanner. It looks like we are including it on every page, but based on that library we only want to include it on the pages that require it.

danfox01 commented 6 years ago

@martypowell it should just be these two pages:

martypowell commented 6 years ago

10-4, are we able to test this in dev?

jdomasky commented 5 years ago

I had an issue related to SmartBanner this week:

On January 23 around 1 p.m., I used IE 11 to browse http://staging.baltimorecountymd.gov/economicdev/jobconnectortoolkit.html

I clicked a PDF link on the page and it did not open in a new window, as it should. The PDF displayed in the IE 11 window using the Acrobat Pro PDF browser plugin.

I clicked the Back arrow and returned to the page. That is when I saw the pop-up (2nd screenshot, below). When I clicked the Yes button in the pop-up, the IE inspector tool opened in a separate window with the Console pane displayed (1st screenshot).

script error on dot_gov page in staging - pop-up 20190123

script error on dot_gov page in staging - console 20190123

martypowell commented 5 years ago

@jdomasky thanks, this has been bothering me for sometime, hopefully we can take a look soon.

@tmccoy529 @sgrg1

sgrg1 commented 5 years ago

Issue fixed, waiting for it to move to dev environment

tmccoy529 commented 5 years ago

@danfox01 This has been moved to dev for testing.

martypowell commented 5 years ago

@tmccoy529 @sgrg1 this can be removed from the two pages listed above @danfox01 made the decision to remove this and that sounds like a delightful idea to me.

martypowell commented 5 years ago

@danfox01 the script has been removed as a result of 1.18.5. The banner still exists in production. on the pages identified in this thread. Do you want me to the banner from these pages?

danfox01 commented 5 years ago

@martypowell thanks, if you don't mind, that's be fantastic.

martypowell commented 5 years ago

@danfox01 these pages have been updated, and i confirmed the banners are not showing in ios or android mobile browsers as tested on browserstack.