baltimorecounty / baltimorecountymd.gov-assets

Baltimore County Government Website Assets
3 stars 1 forks source link

BaltCoGo: Allow categories that are not in Citysourced #249

Closed danfox01 closed 5 years ago

danfox01 commented 5 years ago

This is a high-priority enhancement request to add functionality to the BaltCoGo web front-end. Requirements

All other functionality for the existing app should remain in place, including:

martypowell commented 5 years ago

New Id's should be in this format: D00001, D00002 ...

danfox01 commented 5 years ago

Example issue:

Top-Level Category:

Second-Level Categories:

Alert text can be placeholder now.

tmccoy529 commented 5 years ago

@danfox01 This example of Water Supply Issues, are you saying this needs to be the top most drop down item or were you just saying this is the top level of the new item and these are the sub levels to it but it should still appear in the list in alphabetical order?

danfox01 commented 5 years ago

@tmccoy529 Sorry, good question. This just indicates the addition of a new top level category with a few secondary items below it. The Water Issues category itself should be in alpha order in the main list.

In other words, it's the second thing you said.

tmccoy529 commented 5 years ago

@danfox01 will do, thanks Dan

tmccoy529 commented 5 years ago

@danfox01 I have added changes to hide the top tabs, description box and next button when one of these options is selected. We will have to update the readme as there is a way now to disable the form by adding a value of shouldDisableForm to a category now.

danfox01 commented 5 years ago

Fantastic. Am I good to begin testing in dev?

tmccoy529 commented 5 years ago

Yes its in dev at the moment.

danfox01 commented 5 years ago

@jdomasky is still testing, but based on the preliminary results, we're seeing just one major issue:

The dummy IDs (e.g., D000004) don't seem to work with the query string feature to preselect an issue type. For example, this link should preselect "Water Meter Missing" but doesn't https://dev.baltimorecountymd.gov/iwant/report.html?categoryId=D000004

tmccoy529 commented 5 years ago

@danfox01 So the URL is looking for an integer but our new dummy ID's are strings and so this wont work. However, I'm looking into whether or not we need to check if its an integer or not. Doesn't really seem to be needed so hoping its an easy enough fix.

tmccoy529 commented 5 years ago

@jdomasky @danfox01 this is back out in dev with updates to handle the new ID's

danfox01 commented 5 years ago

Thanks @tmccoy529!

@jdomasky, please run through the test plan for the dummy ID's once more and verify the queries are working as expected. I also updates the notes so they are unique to each issue type -- you can verify that they update when issues are changed. Thanks!

jdomasky commented 5 years ago

OK! Will retest today, shortly.

jdomasky commented 5 years ago

@tmccoy529 I completed the additional testing in dev, as requested. I retested the Water Supply Issue IDs again in IE11 and Chrome, and verified that direct linking via URL query is working now. Thanks to @danfox01's custom notes, I verified the conditional notes are updating when the Water Supply Issue subcategory is changed (when the form is disabled).

danfox01 commented 5 years ago

@tmccoy529 and @martypowell, this looks good to go. You think we can release this off hours next week? If so I will put in the change control.

martypowell commented 5 years ago

@danfox01 any reason to not to do this during work hours?

danfox01 commented 5 years ago

@martypowell, it's because we haven't touched this in a while and it's getting a lot of visibility from the Exec Office at the moment. Just keeping OIT's change control process in mind because of the affected customers if something goes wrong.

If you have a good reason to do it during work hours and you're confident, I am open to it.

danfox01 commented 5 years ago

Chatted offline about this. We will release during business hours since this is more akin to continuous integration and is low risk. Will also ensure better availability of resources for training and testing.

danfox01 commented 5 years ago

Confirmed this was released to prod in v1.18. Nice job @tmccoy529 and @martypowell.

Will have @jdomasky do a final round of testing when he is back in the office, but my quick testing today shows everything in good shape.