search

baltimorecounty / baltimorecountymd.gov-assets

Baltimore County Government Website Assets
3 stars 1 forks source link

Moved CSS styles to red-inside #276

Open theilman7 opened 5 years ago

theilman7 commented 5 years ago

Please reference issue: Move agency contact module styles from agency-homepage.css to red-inside.css #275

martypowell commented 5 years ago

@danfox01 @theilman7 we actaully do not want to update red-inside, that is an existing style sheet that kinda lived on from pre github days. This should be integrated into the inside-responsive template i believe.

It would probably be worth creating a new file for this stuff, as it seems like it's pretty focused, and then include it with the others. If you have any questions, please let me know.

danfox01 commented 5 years ago

@martypowell thanks the info on this. @theilman7 as long as you are comfortable, please go ahead with Marty's recommendation.

theilman7 commented 5 years ago

@martypowell @danfox01 Thanks Marty! I can work on doing that. Going to follow up with Marty to see if there is a preferred file under the /partials directory you would prefer these styles added to. I see inside-responsive.scss @imports quite a bit from there, so I want to be sure I place it in the desired file. Alternatively, I can create a file (maybe sidebar or enhancements?) and @import it in to inside-responsive.scss.

Thanks again all!

theilman7 commented 5 years ago

Revised and pushed new commit based upon feedback. Let me know when you have a chance to review and if you would like to see anything revised. @martypowell @danfox01

theilman7 commented 5 years ago

@danfox01 @martypowell Just wanted to ping a friendly reminder on this thread regarding the updated pull request.

Thanks all! _TH

martypowell commented 5 years ago

@theilman7 this looks good, has this been uploaded to dev?